Skip to content

Update version to 25.4.1#499

Merged
jgfoster merged 2 commits intoOpen-Acidification:mainfrom
jgfoster:version
Apr 14, 2025
Merged

Update version to 25.4.1#499
jgfoster merged 2 commits intoOpen-Acidification:mainfrom
jgfoster:version

Conversation

@jgfoster
Copy link
Member

No description provided.

@jgfoster jgfoster requested a review from Copilot April 14, 2025 16:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • extras/device_client/lib/model/version.dart: Language not supported

src/Version.h Outdated
@@ -1 +1 @@
#define VERSION "v25.3.1 "
#define VERSION "v25.3.1-2-g5317d"
Copy link

Copilot AI Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version string defined does not match the intended update of 25.4.1 as specified in the PR title. Consider updating it to "v25.4.1" to ensure consistency.

Suggested change
#define VERSION "v25.3.1-2-g5317d"
#define VERSION "v25.4.1"

Copilot uses AI. Check for mistakes.
@jgfoster jgfoster requested a review from Copilot April 14, 2025 16:56
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • extras/device_client/lib/model/version.dart: Language not supported

@@ -1 +1 @@
#define VERSION "v25.3.1 "
#define VERSION "v25.4.1 "
Copy link

Copilot AI Apr 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are trailing spaces in the version string. Consider removing the extra whitespace for consistency and to avoid potential formatting issues.

Suggested change
#define VERSION "v25.4.1 "
#define VERSION "v25.4.1"

Copilot uses AI. Check for mistakes.
@jgfoster jgfoster merged commit fa7576d into Open-Acidification:main Apr 14, 2025
14 checks passed
@jgfoster jgfoster deleted the version branch April 14, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants